<html>
<head><meta charset="utf-8"><title>Merge #134 · wg-async-foundations · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/index.html">wg-async-foundations</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/Merge.20.23134.html">Merge #134</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="234164862"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/Merge%20%23134/near/234164862" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/Merge.20.23134.html#234164862">(Apr 12 2021 at 14:08)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span> I think <a href="https://github.com/rust-lang/rust/issues/134">#134</a> is ready to go, but there's one comment that you should address: <a href="https://github.com/rust-lang/wg-async-foundations/pull/134#discussion_r611553032">https://github.com/rust-lang/wg-async-foundations/pull/134#discussion_r611553032</a></p>



<a name="234164928"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/Merge%20%23134/near/234164928" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/Merge.20.23134.html#234164928">(Apr 12 2021 at 14:09)</a>:</h4>
<p>resolved</p>



<a name="234164958"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/Merge%20%23134/near/234164958" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/Merge.20.23134.html#234164958">(Apr 12 2021 at 14:09)</a>:</h4>
<p><span class="user-mention" data-user-id="400241">@Zeeshan Ali</span> didn't listen to directions and modified <code>SUMMARY.md</code> :P</p>



<a name="234164996"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/Merge%20%23134/near/234164996" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/Merge.20.23134.html#234164996">(Apr 12 2021 at 14:09)</a>:</h4>
<p>(which is fine)</p>



<a name="234165030"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/Merge%20%23134/near/234165030" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/Merge.20.23134.html#234165030">(Apr 12 2021 at 14:10)</a>:</h4>
<p>but hence the big green button doesn't work!</p>



<a name="234165068"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/Merge%20%23134/near/234165068" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/Merge.20.23134.html#234165068">(Apr 12 2021 at 14:10)</a>:</h4>
<p>I get such satisfaction from clicking it</p>



<a name="234168174"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/Merge%20%23134/near/234168174" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Zeeshan Ali <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/Merge.20.23134.html#234168174">(Apr 12 2021 at 14:26)</a>:</h4>
<p>Which directions? I'll rebase now <a href="https://github.com/rust-lang/wg-async-foundations/pull/134#issuecomment-817739945">as promised</a> and all's good to merge then.</p>



<a name="234168821"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/Merge%20%23134/near/234168821" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Zeeshan Ali <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/Merge.20.23134.html#234168821">(Apr 12 2021 at 14:30)</a>:</h4>
<p>you'll get to click it, don't worry. :)</p>



<a name="234173232"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/Merge%20%23134/near/234173232" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Zeeshan Ali <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/Merge.20.23134.html#234173232">(Apr 12 2021 at 14:55)</a>:</h4>
<p>Ah, i wasn't supposed to touch <code>SUMMARY.md</code>, sorry I forgot. :( Next time. You can push the green button now. :)</p>



<a name="234173880"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/Merge%20%23134/near/234173880" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/Merge.20.23134.html#234173880">(Apr 12 2021 at 14:59)</a>:</h4>
<p>thanks <span class="user-mention" data-user-id="400241">@Zeeshan Ali</span> &lt;3</p>



<a name="234173948"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/Merge%20%23134/near/234173948" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/Merge.20.23134.html#234173948">(Apr 12 2021 at 14:59)</a>:</h4>
<p>/me pushes it</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>